Update dataone_format_mappings #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial update for #84
|
This looks good to me - why exclude .mat files though? |
|
The .mat files can have different versions associated with them, like with netCDF files. They are not supported enough in R at the moment to easily determine the version. The .raw format can be added as "image/x-raw", but there could be some cases where .raw does not represent an image file. |
|
Makes sense. I'm going to merge this one. I also think issue #29 should be closed already. I think it already guesses the format for you (now it can guess better though!) |
laijasmine
pushed a commit
that referenced
this pull request
Oct 2, 2020
Update dataone_format_mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates supported formats except for .mat and .raw files.
Partial update for #84.
Closes #29.