Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized subroutine to read the state variables from the namelist (parse_variables) #783

Merged
merged 49 commits into from
Feb 4, 2025
+576 −799
Merged

Generalized subroutine to read the state variables from the namelist (parse_variables) #783

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
17f26ab
Making a generic subroutine to read model_nml:model_state_variables i…
mjs2369 Nov 12, 2024
179d34f
Adding a unit test for the state var table read
mjs2369 Nov 13, 2024
f18942e
Fixing file name for dev test
mjs2369 Nov 13, 2024
c0bb758
Changing the name of the subroutine to get_state_variables
mjs2369 Dec 10, 2024
1914a42
Changing the name of the dev test to better fit the subroutine name and
mjs2369 Dec 10, 2024
c168bbe
Removing MOM6 version of subroutine and making necessary adjustments
mjs2369 Dec 10, 2024
e82df2e
including other needed input.nml file for test
mjs2369 Dec 10, 2024
f177c69
Removing MPI from dev test
mjs2369 Dec 12, 2024
ccf37db
Adding an interface to create 2 distinct subroutines for get_state_va…
mjs2369 Dec 12, 2024
7381c2b
Updating MOM6 model_mod to use new interface
mjs2369 Dec 12, 2024
914468f
Replacing CAM-FV version of the routine with generic in default_model…
mjs2369 Dec 12, 2024
15e984f
Replacing CAM-SE version of the routine with generic in default_model…
mjs2369 Dec 12, 2024
6ed2022
Removing forgotten print statements from ca-fv model_mod
mjs2369 Dec 12, 2024
7336795
Using separate namelist groups in a single input.nml as opposed to us…
mjs2369 Dec 12, 2024
14352e1
Replacing WRF_HYDRO version of the routine with generic in default_mo…
mjs2369 Dec 12, 2024
4d996bd
WRF_HYDRO: Removing varibles that are no longer used due to changes
mjs2369 Dec 16, 2024
b1f0878
MOM6: Removing varibles that are no longer used due to changes
mjs2369 Dec 16, 2024
80a63e1
Replacing POP version of the routine with generic in default_model_mod
mjs2369 Dec 16, 2024
d76f1cb
Replacing aether_lat-lon version of the routine with generic in defau…
mjs2369 Dec 16, 2024
979a9cf
Replacing NOAH version of the routine with generic in default_model_mod
mjs2369 Dec 16, 2024
3e629cf
Replacing MITgcm_ocean version of the routine with generic in default…
mjs2369 Dec 16, 2024
0d759f3
Replacing CICE version of the routine with generic in default_model_mod
mjs2369 Dec 16, 2024
4d790b5
Fixing print statement in default_model_mod
mjs2369 Dec 17, 2024
83ad490
- Make function instead of subroutine
mjs2369 Jan 9, 2025
4da5986
Updating dev test; remove prints and test all components of the state…
mjs2369 Jan 9, 2025
022e6ba
Use parse_variables in the 3d template model_mod
mjs2369 Jan 9, 2025
87e21ba
Merge branch 'main' into get_state_variables
mjs2369 Jan 9, 2025
23c8d84
Fix typo in state_structure_mod.f90
mjs2369 Jan 9, 2025
ceeb76d
standard: .eqv. for logicals
hkershaw-brown Jan 13, 2025
e5057da
fix: use QTY_NAME rather than hardcoded number
hkershaw-brown Jan 13, 2025
b0c2a00
chore: add test_parse_variables program to gitignore
hkershaw-brown Jan 13, 2025
a4b10d6
Fix state_var_type%netcdf_var_names character length in default_model…
mjs2369 Jan 13, 2025
79cd8ea
Add needed trim to default_model_mod.f90
mjs2369 Jan 13, 2025
b66ee82
Making final adjustments and fixes to the dev test
mjs2369 Jan 13, 2025
d6bebae
Reverting the MITgcm_ocean model_mod to the original (cannot use the new
mjs2369 Jan 13, 2025
e78fbda
Adding the logic to use the default state variables if model_state_va…
mjs2369 Jan 13, 2025
807cfe5
Updating the domain_type%method field to include state_type and fixin…
mjs2369 Jan 29, 2025
548190e
Reverting changes to noah model_mod back to main (original)
mjs2369 Jan 29, 2025
79ee8bf
Merge branch 'main' into get_state_variables
mjs2369 Jan 30, 2025
29ebab0
Merge branch 'main' into get_state_variables
hkershaw-brown Jan 31, 2025
3838d55
Merge branch 'main' into get_state_variables
hkershaw-brown Feb 3, 2025
a95013b
test_parse_variables is a serial program
hkershaw-brown Feb 3, 2025
57734f1
comment typo, namelist item is state_variables
hkershaw-brown Feb 3, 2025
e7bb723
chore: remove old svn info
hkershaw-brown Feb 3, 2025
d43f7ee
comment on relative size MAX_STATE_VARIABLE_FIELDS, MAX_STATE_VARIABL…
hkershaw-brown Feb 3, 2025
9e367a6
comment typo, the namelist item is called state_variables
hkershaw-brown Feb 3, 2025
120d83a
max number of state variables 1000
hkershaw-brown Feb 4, 2025
a7bf0bf
catch if number of state variables gets too big
hkershaw-brown Feb 4, 2025
9d0a17a
bump conf.py and CHANGELOG
mjs2369 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add test_parse_variables program to gitignore
@hkershaw-brown
hkershaw-brown committed Jan 13, 2025
commit b0c2a00c788c859a448f320f38ce9b22c32fe791
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -207,6 +207,7 @@ test_normal_dist
test_beta_dist
test_kde_dist
test_window
test_parse_variables

# Directories to NOT IGNORE ... same as executable names
# as far as I know, these must be listed after the executables