-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove automated deployment to staging from merge into main branch #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayeaye
requested review from
botanical,
ividito,
smohiudd and
sandrahoang686
October 10, 2024 21:48
botanical
reviewed
Oct 11, 2024
botanical
reviewed
Oct 11, 2024
@@ -136,9 +136,7 @@ jobs: | |||
|
|||
- name: Get environment configuration for target branch | |||
run: | | |||
if [ "${{ github.base_ref }}" == "main" ]; then | |||
./scripts/get-env.sh "veda-backend-uah-staging-env" | |||
elif [ "${{ github.base_ref }}" == "develop" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
botanical
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion but I think this looks good
Co-authored-by: Jennifer Tran <[email protected]>
botanical
approved these changes
Oct 14, 2024
anayeaye
added a commit
that referenced
this pull request
Oct 15, 2024
…lidation, add nlcd colormap (#434) **Breaking** feat(routes)!: remove cloudfront distribution and custom alternate domain from backend #422 **Added** feat(raster-api): added custom NLCD colormap #433 feat: add ecr endpoint #432 **Fixed** fix(tests): #425 fix(ingest): improved datetime validations #419 **Changed** ci: remove automated deployments to staging #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/NASA-IMPACT/veda-deploy/issues/52
What?