Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove automated deployment to staging from merge into main branch #438

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

anayeaye
Copy link
Collaborator

@anayeaye anayeaye commented Oct 10, 2024

Issue

https://github.com/NASA-IMPACT/veda-deploy/issues/52

What?

  • This PR removes the github workflow that deploys to the staging environment and the pre-deploy cdk diff for the staging environment because it is now managed in veda-deploy.
  • This PR modifies the automated dev branch and instance deployment to use the same cdk-deploy/action that is used in veda-deploy

@@ -136,9 +136,7 @@ jobs:

- name: Get environment configuration for target branch
run: |
if [ "${{ github.base_ref }}" == "main" ]; then
./scripts/get-env.sh "veda-backend-uah-staging-env"
elif [ "${{ github.base_ref }}" == "develop" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@botanical botanical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion but I think this looks good

@anayeaye anayeaye merged commit ad5d5e5 into develop Oct 14, 2024
4 checks passed
@anayeaye anayeaye deleted the ci/remove-automated-staging-deployment branch October 14, 2024 17:22
anayeaye added a commit that referenced this pull request Oct 15, 2024
…lidation, add nlcd colormap (#434)

**Breaking**
feat(routes)!: remove cloudfront distribution and custom alternate
domain from backend #422

**Added** 
feat(raster-api): added custom NLCD colormap
#433
feat: add ecr endpoint
#432

**Fixed**
fix(tests): #425
fix(ingest): improved datetime validations
#419

**Changed**
ci: remove automated deployments to staging
#438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants