fix: fix transaction unit test #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Sep 12, 2024
| @@ -208,7 +210,7 @@ | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| @pytest.fixture(autouse=True) | |||
There was a problem hiding this comment.
using autouse=True will make sure the fixture is ran for each test
smohiudd
approved these changes
Sep 12, 2024
vincentsarago
commented
Sep 12, 2024
| @@ -53,59 +53,59 @@ def setup( | |||
| self.invalid_stac_collection = invalid_stac_collection | |||
| self.invalid_stac_item = invalid_stac_item | |||
|
|
|||
| def test_post_invalid_collection(self): | |||
| async def test_post_invalid_collection(self): | |||
There was a problem hiding this comment.
the function weren't async while the api_client fixture is async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Link to relevant GitHub issue
What?
Why?
Testing?