feat(release)!: Improve stac integration tests, add optional web acl configuration for cloudfront, titiler-pgstac v1 upgrade #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issue [GSD-3535 Ensure CloudFront distributions have WAF enabled ](NASA-IMPACT/veda-architecture#448) ### What? - Added env var and construct changes to incorporate optional web acl ### Why? - security requirement ### Testing? - tested using mcp-test and checked that setting `VEDA_SHARED_WEB_ACL_ID` works as expected and omitting `VEDA_SHARED_WEB_ACL_ID` does not enable firewall to cloudfront
upgrade to titiler-pgstac 1.3.0
anayeaye
approved these changes
Jul 30, 2024
|
We should probably set something up that if an approval is made and commits go in, approvals are removed... looks like if we hit merge now, changes that weren't reviewed/for this release will go in too 😱 |
anayeaye
approved these changes
Aug 1, 2024
smohiudd
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Breaking
✨ Added
🪙 Changed/Updated
🩹 Fixed