Skip to content

change lgo to boolean primitive #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

change lgo to boolean primitive #36

merged 1 commit into from
Apr 16, 2025

Conversation

joswig
Copy link
Contributor

@joswig joswig commented Mar 18, 2025 •
edited
Loading

Changes to test data only to comply with assumptions other tools (jpl_sequence and seqgen) are making on load and go structure

@joswig joswig requested a review from a team as a code owner March 18, 2025 18:53
@joswig joswig requested a review from goetzrrGit March 18, 2025 18:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joswig joswig requested a review from shaheerk94 March 18, 2025 18:54
ewferg
ewferg approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@ewferg ewferg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is test data and not a change to the schema, I have no issues

cartermak
cartermak approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@cartermak cartermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree both that I'm happy to take this quick change to test files, and that this matches our conventions.

shaheerk94
shaheerk94 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@shaheerk94 shaheerk94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Taifun that the lgo metadata format used in this test matches SEQGEN's expectations. Confirmed as well that jpl_sequence expects "lgo": false instead of "lgo": {"boolean": false}.

@cartermak cartermak merged commit 4c834dd into develop Apr 16, 2025
2 checks passed
@cartermak cartermak deleted the fix/lgo_type branch April 16, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewferg ewferg ewferg approved these changes

@cartermak cartermak cartermak approved these changes

@shaheerk94 shaheerk94 shaheerk94 approved these changes

@goetzrrGit goetzrrGit Awaiting requested review from goetzrrGit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joswig @ewferg @cartermak @shaheerk94