Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests invalidated by legacy removal changes #183

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

jvigliotta
Copy link
Collaborator

closes #172

Update unit tests for legacy angular removal.

@jvigliotta jvigliotta requested a review from davetsay July 11, 2024 23:11
it('contains all telemetry data for all objects', () => {
const rows = ExportDataTask.prototype.exportCSV.calls.mostRecent().args[0];
const options = ExportDataTask.prototype.exportCSV.calls.mostRecent().args[1];
const headers = options.headers;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable headers.
Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay merged commit 3360016 into main Jul 12, 2024
2 checks passed
@davetsay davetsay deleted the omm-172 branch July 12, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update any unit tests that were invalidated during legacy removal
2 participants