Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create codeql_scrub.yml to add scrub post processing to scans #168

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Create codeql_scrub.yml to add scrub post processing to scans #168

merged 3 commits into from
Apr 3, 2024

Conversation

davetsay
Copy link
Collaborator

@davetsay davetsay commented Apr 1, 2024 •
edited
Loading

@davetsay davetsay added this to the MC2412 Sprint 2 milestone Apr 1, 2024
lylebarner
lylebarner requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@lylebarner lylebarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you make the changes outlined in the comments you should be good to go.

.github/workflows/codeql_scrub.yml Outdated Show resolved Hide resolved
.github/workflows/codeql_scrub.yml Show resolved Hide resolved
@davetsay davetsay requested a review from lylebarner April 2, 2024 17:00
@davetsay
Copy link
Collaborator Author

davetsay commented Apr 2, 2024

I think if you make the changes outlined in the comments you should be good to go.

Thanks for the review. I've made the changes @lylebarner

@jvigliotta jvigliotta self-requested a review April 3, 2024 16:27
jvigliotta
jvigliotta approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lylebarner
lylebarner approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@lylebarner lylebarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The action seems to be generating the appropriate output files.

@davetsay davetsay merged commit a4fe8dd into main Apr 3, 2024
3 checks passed
@davetsay davetsay deleted the davetsay-patch-1 branch April 3, 2024 21:46
@davetsay
Copy link
Collaborator Author

davetsay commented Apr 3, 2024

Looks good! The action seems to be generating the appropriate output files.

Thanks so much for your help @lylebarner !

@davetsay davetsay mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lylebarner lylebarner lylebarner approved these changes

@jvigliotta jvigliotta jvigliotta approved these changes

Assignees
No one assigned
Labels
other security_scan
Projects
None yet
Milestone
MC2412 Sprint 2
Development

Successfully merging this pull request may close these issues.

Configure CodeQL to use SCRUB for external analysis
3 participants
@davetsay @jvigliotta @lylebarner