Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54 agent details modal #64

Merged
merged 5 commits into from
Jan 3, 2024
Merged

54 agent details modal #64

merged 5 commits into from
Jan 3, 2024

Conversation

njbrunner
Copy link
Contributor

Changes:

  • Removed old Agent.vue file
  • Added new AgentModal.vue file to replace the above
  • Added new logic to launch modal on row click
  • Added styling to agent table
  • Updated styling of reports in modal
  • Updated styling of parameter form in modal
  • Added toasts to display and handle responses and errors after sending parameters

Testing Suggestions:

  • Test the agent table to ensure modal responds properly
  • Test the reports dropdown and table display
  • Test the send parameters form and ensure the toasts response properly

@njbrunner njbrunner linked an issue Jan 1, 2024 that may be closed by this pull request
Agent details modal #54
Closed
4 tasks
@njbrunner njbrunner added this to the ANMS v1.1.0 milestone Jan 1, 2024
@d-linko d-linko self-assigned this Jan 2, 2024
d-linko
d-linko approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@d-linko d-linko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed locally everything loaded and looks good to me

@njbrunner njbrunner merged commit b9c71aa into main Jan 3, 2024
4 checks passed
@njbrunner njbrunner deleted the 54-agent-details-modal branch January 3, 2024 04:46
@d-linko d-linko mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-linko d-linko d-linko approved these changes

@BrianSipos BrianSipos Awaiting requested review from BrianSipos

Assignees

@d-linko d-linko

Labels
None yet
Projects
ANMS
Status: Done
Milestone
ANMS v1.1.0
Development

Successfully merging this pull request may close these issues.

Agent details modal
2 participants
@njbrunner @d-linko