Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI loading indicators part 1 #1589

Merged
merged 37 commits into from
Feb 4, 2025
Merged

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Jan 3, 2025

Improve initial data loading indication. Partially addresses #1581 and #832. General approach is to set various array stores
to null in order to detect if the subscription has returned any results at all yet.

Changes:

  • DataGrid and super-component loading prop to control the ag-grid loading message
  • DataGrid skeleton loading component
  • Track initial load of simulation arguments and display loading message
  • Scheduling goal and condition loading states within a plan
  • Timeline histogram loading state
  • Initial span tracking and loading state
  • Scheduling loading state in plan and constraints page
  • Constraints loading states in plan and constraints page
  • Fix usage of simulation dataset id in one store case
  • Fix initial navbar jerkiness on page load
  • Activity directive loading indication
  • Views loading indication
  • Plan snapshots loading indication
  • Users loading indication
  • Simulation history and argument loading indication
  • Simulation event loading indication
  • Style bug fix for plan loading where several absolutely positioned timeline elements were not relative to the correct parent and were causing overflow after SSR and before UI interactivity

TODO:

  • Management of scheduling conditions within a plan is not working for some reason
  • Document the other loading states not yet addressed

@AaronPlave AaronPlave self-assigned this Jan 3, 2025
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from e7eefdb to 5d6fd20 Compare January 17, 2025 16:19
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from 5d6fd20 to 68f1389 Compare January 17, 2025 17:45
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from 68f1389 to 733bf1e Compare January 17, 2025 17:54
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from 733bf1e to 58859a8 Compare January 22, 2025 16:19
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from 55c4faf to d1d8d9d Compare January 22, 2025 17:04
@AaronPlave AaronPlave changed the title Feat/loading indicators part 1 UI loading indicators part 1 Jan 22, 2025
@AaronPlave AaronPlave force-pushed the feat/loading-indicators-part-1 branch from 0386f34 to 5030478 Compare February 4, 2025 18:08
Copy link

sonarqubecloud bot commented Feb 4, 2025

@AaronPlave AaronPlave merged commit 0803e6d into develop Feb 4, 2025
6 checks passed
@AaronPlave AaronPlave deleted the feat/loading-indicators-part-1 branch February 4, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants