simplify logic on no arg commands #1584
Open
+36
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joswig
had a problem deploying
to
test-workflow
GitHub Actions
Failure
joswig
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
requested changes
Dec 29, 2024
| }; | ||
| } | ||
| if ((argsNode && argsNode.length < expectedArgSize) || (!argsNode && expectedArgSize > 0)) { | ||
| const { from, to } = getFromAndTo(argsNode ?? [stemNode]); |
There was a problem hiding this comment.
Change this to
const { from, to } = getFromAndTo(argsNode?.length ? argsNode : [stemNode]);
That way it will highlight the command stem instead of the TimeTag
There was a problem hiding this comment.
here is the commit for the code pushed:
* Was returning a min or max that was outside the scope of the editor. * Update custom folder after addressing this issue.
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Dec 30, 2024
| }; | ||
| } | ||
| if ((argsNode && argsNode.length < expectedArgSize) || (!argsNode && expectedArgSize > 0)) { | ||
| const { from, to } = getFromAndTo(argsNode ?? [stemNode]); | ||
| const pluralS = expectedArgSize - (argsNode?.length ?? 0) > 1 ? 's' : ''; |
There was a problem hiding this comment.
We have a pluralize utility function in utilities/text.ts if you'd like to use that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not clear on the rationale for making a distinction on whether or not an arguments node is present, I don't expect the user to know and what is important is that the argument counts match. Let me know if I'm missing some nuance here.