Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GLTFCesiumRTCExtension.d.ts): implements THREE.js's GLTFLoaderPlugin #871

Merged

Conversation

sguimmara
Copy link
Contributor

This typing is necessary to register this extension on the three.js GLTFLoader.

@gkjohnson
Copy link
Contributor

Thanks! Can you add this on the other GLTF Extensions, as well? (MeshFeaturesExtension, StructuralMetadataExtension)

This typing is necessary to register this extension on the three.js GLTFLoader.
@sguimmara sguimmara force-pushed the typing-GLTFCesiumRTCExtension branch from 686cc09 to 6822f40 Compare December 16, 2024 15:12
@sguimmara
Copy link
Contributor Author

StructuralMetadataExtension

Yes, updated the other files as well :)

While looking at the GLTFLoaderPlugin API, it seems very similar to what you did for the TilesRenderer: an object that exposes optional methods that are called by the invoke plugin mechanism. It might be a good idea to add types for those plugins as well, what do you think ?

Something like that (truncated only for the fetchData method):

export interface TilesRendererPlugin {
        ...
	fetchData?: ( url: RequestInfo, options: RequestInit ) => Promise<Response>;
        ...
}

@gkjohnson
Copy link
Contributor

Thanks! I'll respond to the tiles plugin types proposal in the other PR.

@gkjohnson gkjohnson merged commit 846b37c into NASA-AMMOS:master Dec 17, 2024
2 checks passed
@gkjohnson gkjohnson added this to the v0.3.46 milestone Dec 17, 2024
@sguimmara sguimmara deleted the typing-GLTFCesiumRTCExtension branch December 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants