Fix errors in the PNTS Draco decoding docs #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Nov 21, 2024
README.md
Outdated
| @@ -170,7 +170,7 @@ scene.add( tilesRenderer2.group ); | |||
|
|
|||
| ## Adding DRACO Decompression Support | |||
|
|
|||
| Adding support for DRACO decompression within the GLTF files that are transported in B3DM and I3DM formats. The same approach can be used to add support for KTX2 and DDS textures. | |||
| Adding support for DRACO decompression within the GLTF files that are transported in B3DM and I3DM formats. The same approach can be used to add support for KTX2 and DDS textures. Note that GLTF decoding and PNTS decoding require separate decoders. | |||
There was a problem hiding this comment.
I'm not sure what this added line means. Can it be removed or clarified?
There was a problem hiding this comment.
In the current docs, the selected draco decoder from unpkg uses the GLTF branch, which does not work for compressed PNTS files. This is a really easy detail to miss IMO, I added this line to clarify that. I'll reword things
https://github.com/mrdoob/three.js/tree/dev/examples/jsm/libs/draco
vs
https://github.com/mrdoob/three.js/tree/dev/examples/jsm/libs/draco/gltf
There was a problem hiding this comment.
Oh I see now... how annoying. New wording looks better - thanks!
|
Hopefully this language is clearer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PNTS decoding docs reference the wrong decoder as well as the wrong loader. Spent a bit of time hair pulling and hunting down confusing errors till I realized this.