[3/n][vm-rewrite][Move] Update native context extensions to support Cloning #21067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-2
branch
from
c07295c to
1c7a767
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
a1a87a0 to
bba3dc9
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…loning, and let extension determine how to handle interior mutability. This updates the `NativeContextExtensions` struct to be `Clone`able. This updates the `Box<dyn Tid<'a>>` to a `Rc<dyn Tid<'a>>` and the extension is responsible for handling interior mutability. As a helper struct the `NativeContextMut` was added to allow for easy writing/handling of native extensions that need interior mutability. NB: The code in the PR may not be working as future PRs will build on top of this. In particular, for this PR, the changes to the object runtime/sui-adapter/sui-execution natives will be needed.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
bba3dc9 to
e390092
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
reviewed
Feb 5, 2025
| /// | ||
| /// Note that this is _not_ threadsafe. If you need threadsafe access to the `T` you will need to | ||
| /// handle that within `T'`s type (just like in the previous implementation of the | ||
| /// `NativeContextExtensions`). |
There was a problem hiding this comment.
I am a little confused. It appears we are making it so that all mutability needs to be explicit when building up the native context extension, whereas before everything was arbitrarily mutable. What is the motivation for this change?
cgswords
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
NativeContextExtensionsstruct to beCloneable. This updates theBox<dyn Tid<'a>>to aRc<dyn Tid<'a>>and the extension is responsible for handling interior mutability.As a helper struct the
NativeContextMutwas added to allow for easy writing/handling of native extensions that need interior mutability.NB: The code in the PR may not be working as future PRs will build on top of this. In particular, for this PR, the changes to the object runtime/sui-adapter/sui-execution natives will be needed.