[move][move-vm][rewrite][cleanup 3/n] Add constants to arena, use pointers for them #21051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
changed the title
tzakian
approved these changes
Feb 4, 2025
external-crates/move/crates/move-vm-runtime/src/execution/interpreter/eval.rs
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Outdated
Show resolved
Hide resolved
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
force-pushed
the
cgswords/vm_arena_limits
branch
from
ca7cf22 to
dbcd7d5
Compare
Base automatically changed from
cgswords/vm_arena_limits
to
cgsworsd/vm_rewrite_jit_opt
February 5, 2025 03:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Place constants into the arena (at least their head pointers), and use those pointers in the AST
Test plan
All tests still pass
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.