[move] merge seal package #469
Open
+669
−581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyqvq
force-pushed
the
joy/upgrade-seal
branch
from
f60105d to
72ac6c0
Compare
joyqvq
commented
Feb 10, 2026
| // Copyright (c), Mysten Labs, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Permissionless registration of a key server: |
Collaborator
Author
There was a problem hiding this comment.
this is the file to review
joyqvq
commented
Feb 11, 2026
| committee.check_rotation_consistency(&old_committee); | ||
| let old_committee_id = object::id(&old_committee); | ||
| let key_server = dof::remove<ID, KeyServer>(&mut old_committee.id, old_committee_id); | ||
| key_server.assert_committee_server_v2(); |
Collaborator
Author
There was a problem hiding this comment.
not needed since its done in key_server.move when updating partial key servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove seal_testnet and make it part of seal to prepare for seal pkg upgrade. also added more validations and test files.
Test plan
How did you test the new or updated feature?