[docs] add missing pattern entries for account_based and key_request #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest
ExamplePatterns.md documents 5 of the 7 patterns in move/patterns/sources/.
This adds the two missing entries:
- account_based: address-based encryption with no on-chain state
- key_request: two-step pattern separating policy evaluation from seal_approve
Also fixes a typo in CONTRIBUTING.md ("ay" → "at").
Danny-Devs
requested review from
abhinavg6,
benr-ml,
jonas-lj and
joyqvq
as code owners
- remove backticks (zero in existing patterns) - em-dash to semicolon (matches doc convention) - trim implementation jargon to user-facing language - drop CONTRIBUTING.md typo fix (their policy ignores typo PRs)
Danny-Devs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExamplePatterns.md documents 5 of the 7 access patterns in
move/patterns/sources/, butaccount_basedandkey_requestare missing. This adds both entries following the existing style (use-case-first, single paragraph, link to Move source).Placement:
account_basedis inserted between Private data and Allowlist to follow a complexity gradient (single owner → specific address → group).key_requestis placed last because it's a meta-pattern that wraps other patterns rather than defining its own access policy.Also fixes "ay" → "at" in CONTRIBUTING.md line 27.
Written with the help of Claude Code.
Test plan
mkdocs serve