New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] `RNS` Resolution #4363

Open

ahsan-javaiid wants to merge 1 commit into MyCryptoHQ:master from ahsan-javaiid:fix/rns-resolution

ahsan-javaiid commented Mar 7, 2023

Description

This PR fixes RNS resolution issue on send screen. There are two reasons due to which RNS names are not resolving.

Network is hardcoded in lookup field component here:

MyCrypto/src/components/GeneralLookupField.tsx

Line 142 in 457ec2f

const provider = new ProviderHandler(ethNetwork);
In case of RSK network RPC provider does not know RNS registry address:

MyCrypto/src/services/EthService/network/helpers.ts

Line 28 in 457ec2f

return new StaticJsonRpcProvider(connection, chainId);

which in case of eth, points to correct address.

Changes

Remove hardcoded network in lookup field component
Set RNS registry address inside provider in case of RSK network

Demo

mycrypto-demo.mp4

Steps to test

Select RSK network
Enter any rns name in the address field
Name should resolve to address


          fix: fix rns resolution

dffacee

ahsan-javaiid force-pushed the fix/rns-resolution branch from 0ebf443 to dffacee Compare

March 7, 2023 14:20

Contributor

alepc253 commented Mar 8, 2023

@FrederikBolding could you please take a look?

thisisyou33-publishing-networks approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet