Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass.muxi tech.xyz auth fix #29

Open
wants to merge 10 commits into
base: refactor-pass
Choose a base branch
from

Conversation

qingxuanying
Copy link
Contributor

No description provided.

Dockerfile Outdated
# Build server file
RUN npm install --registry=https://registry.npm.taobao.org
#Build server file
RUN yarn config set registry https://registry.npm.taobao.org/ #��Դ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#»»Ô´ 这个是啥

package.json Outdated
@@ -17,7 +17,8 @@
"react-router-native": "^5.0.1",
"react-scripts": "3.1.1",
"store": "^2.0.12",
"whatwg-fetch": "^3.0.0"
"whatwg-fetch": "^3.0.0",
"yarn": "^1.22.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn 不用放到依赖里吧

@@ -2,10 +2,6 @@ import React from 'react';
import './button.css';

class Button extends React.Component {
constructor(props) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥删了

@@ -7,14 +7,14 @@ class Layout extends React.Component {
return (
<div>
<div
className="sign"
// className="sign"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用的删掉

style={{ backgroundImage: `url(${Background})` }}
className="background"
>
<div className="main">
<div className="logo">
<div className="header">
<img src={icon} className="icon"></img>
<img src={icon} alt="tupian" className="icon"></img>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别用拼音啊

window.location.href =
'http://' + landing + 'landing/?' + 'accessCode=' + accessCode;
// eslint-disable-next-line no-useless-concat
'http://' + landing + '/?accessCode=' + accessCode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 eslint 是要你用字符串模板,不是让你 disable 掉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants