Fix docs for TransformerBlock and remove incompatible functions#37
Open
mashu wants to merge 7 commits intoMurrellGroup:mainfrom
Open
Fix docs for TransformerBlock and remove incompatible functions#37mashu wants to merge 7 commits intoMurrellGroup:mainfrom
mashu wants to merge 7 commits intoMurrellGroup:mainfrom
Conversation
Contributor
mashu
commented
Oct 31, 2025
- Added examples how to use TransformerBlock (not just how to use constructor)
- Removed confusing cross_att_padding_mask and self_att_padding_mask which were returning in log-space and couldn't be used with apply_pad_mask. Now mask can be passed directly.
…ass of the TransformerBlock.
…and cross_att_padding_mask which are not compatible with new apply_pad_mask.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 31.72% 40.43% +8.70%
==========================================
Files 36 33 -3
Lines 769 601 -168
==========================================
- Hits 244 243 -1
+ Misses 525 358 -167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dient tests and ignore UNet for codecov reporting.
Member
…s_att_padding_mask.
Contributor
Author
|
@murrellb I restored the padding masks, there is no diff in the code except for import being one-liner, other changes are improved some docstrings, testing that examples actually work (previous ones were wrong). |
…eck inputs match what the model was constructed with.
…nt depth parameter, if multiplers are provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
