Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 32.32% 32.56% +0.24%
==========================================
Files 28 28
Lines 1915 1916 +1
==========================================
+ Hits 619 624 +5
+ Misses 1296 1292 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
(as discussed) To handle cases where Partitions have more complex structure, and to avoid constraints on new type definitions (eg. requiring keeping the default constructors), we're going to instead go with our own |
Member
|
Note: we must make sure the style and semantics with this and copy_partition_to! are consistent. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deepcopyfunction is notorious for its bad performance in many cases. This pull request implements a method of thecopyfunction forPartitionto avoid calling thedeepcopyfunction. The following example shows an extreme case to speed up initialization of a large tree:Internal constructors of discrete partition types are moved out of the
structscopes because it eliminates the default constructor, which is needed to make the genericcopymethod work for all partition types.NOTE: There are more
deepcopycalls that can be eliminated, but I want to keep each pull request as small as possible. Follow-up pull requests will eliminate moredeepcopys.