Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated routes for Workspaces so that create- and updateWebhook include body #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stefankohler
Copy link

The Schema of workspaces.createWebhookForWorkspace and workspaces.updateWebhookForWorkspaces was missing a body to actually provide the webhook details. This is a required 'field' for the Bitbucket API

@MunifTanjim
Copy link
Owner

MunifTanjim commented May 5, 2021

Hey @stefankohler , Thanks for the PR.

So, most of this library is actually generated from the Bitbucket's API Specification. The src/plugins/register-api-endpoints/routes.json file is generated too. So the next time that file is generated, your changes will go away.

Bitbucket's API Specification is generally buggy and has a lot of problems (like the one you found). To solve that, we have the specification/extras/paths.json file where we put the corrections. This file is applied on top of the Bitbucket's API Specification before the generation process is run.

So, you'll need to add these changes in the specification/extras/paths.json file. And then run the following commands:

# generate routes.json
yarn run generate:routes

# generate types-schemajson
yarn run generate:types-schema

@stefankohler
Copy link
Author

Hi @MunifTanjim,

Thanks for having a look at the PR and for explaining how to actually fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants