Better error checking for link and unlink commands.

[benwoo1110]

saveMVNPConfig() result should be used to ensure removing and adding of world link is saved to config properly.

Also, unlink command shouldn't need to check for MVWorld bcu users should be able to unlink world that they already have deleted/unloaded.

While doing this, also found a bug where it throws NPE (https://bytebin.lucko.me/1sI4jrxziC) if unlinking a toWorld that is not MVWorld which is fixed in this pr.

[nicegamer7]

@benwoo1110 does this build? Just wondering because MVNPConfiguration was renamed to MVNPconfiguration in two spots.

[benwoo1110]

Yep it compiles locally for me, just rebased it with main branch as well, so there is Travis.

[nicegamer7]

Awesome, gonna review soon.

[nicegamer7]

Looks good. Seems "soon" took me a while lol.

[benwoo1110]

Just realised removeWorldLink will have api breakage, as the return type changed.

[nicegamer7]

Yeah I noticed too, but I kind of doubt anyone is using it...

I suppose it would be better not to break the API though.

edit: actually I don't think that's breaking, going from void to boolean. The other way around would certainly be breaking though.

[benwoo1110]

From what I know, there isnt a way to overload return values ;(. We can have a 4.3 release 😄

[benwoo1110]

@nicegamer7 now a new deleteWorldLink method with boolean return while deprecating the old removeWorldLink with void return. Should be good to merge :)