Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legacy Fabric #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

leo60228
Copy link

@leo60228 leo60228 commented May 11, 2021

Legacy Fabric is a fork of Fabric adding support for older versions of the game (currently supporting 1.12.2, 1.8.9, 1.7.10, and 1.6.4, with most development happening for 1.8.9). This PR splits Fabric into "variants" and generates independent metadata for each variant. This variant system was intended to allow future extensibility for projects like Cursed Legacy Fabric, which targets Beta 1.7.3.

I haven't added Legacy Fabric to the MultiMC GUI yet, and I'm not sure the best route to do so (automatically change Install Fabric to Install Legacy Fabric for supported versions, maybe?). However, I've tested the generated metadata and it works fine.

Additionally, Fabric Loader depends on a newer version of Guava than the default for 1.7.10. This can be installed manually, though I've submitted a PR at Legacy-Fabric/fabric-loader-1.8.9#10 to get Guava from Maven. My meta-multimc was generated with that PR applied, so it should work without extra changes.

@Username404-59
Copy link

nice

@leo60228
Copy link
Author

I've added Minecraft Cursed Legacy support on top of this PR in a second branch: https://github.com/leo60228/meta/tree/cursed-legacy

I'm not sure if I'll PR it, though, as Cursed Legacy runs into quite a few more issues than Legacy Fabric.

@thecatcore
Copy link

It would be awesome if this could get updated, now Legacy Fabric works using upstream loader, with our intermediaries.
So overall it should be easier to support.

Note:
A known issue with a fix is, versions using applets (pre-1.6) require the noapplet trait to work with fabric loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants