-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported extension to the W3C Web Extensions API to support Firefox, Chrome, and more #43
base: master
Are you sure you want to change the base?
Changes from 35 commits
9b95fa7
8d26c79
242279b
ade0439
1fb0759
32cce0f
db4af48
ee6ebc2
cdcaf6a
e030be2
3c6bd51
e1c0224
e197902
f7034dc
94de8b5
401b670
fba5f9b
df8e798
0b269e0
dad108c
3bffb71
9e55e6e
0c7bb31
7314929
d320afb
03bfcdc
71fc5e1
abb1f89
ea7d184
f5af8c1
fd78cf0
da0a1f7
83f2989
7f721d6
5df5b9c
4c83f4d
11415a9
c9989c2
77da5de
0f78856
1fe0128
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
"trailing": true, | ||
"smarttabs": true, | ||
"globals" : { | ||
"chrome": true | ||
"chrome": true, | ||
"browser": true | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"tabWidth": 4, | ||
"singleQuote": true, | ||
"trailingComma": "none" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,7 +143,6 @@ module.exports = function (grunt) { | |
dest: '<%= config.dist %>' | ||
}, | ||
html: [ | ||
'<%= config.app %>/popup.html', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good spot! I didn't realize this file was still there |
||
'<%= config.app %>/options.html' | ||
] | ||
}, | ||
|
@@ -240,7 +239,7 @@ module.exports = function (grunt) { | |
'{,*/}*.html', | ||
'styles/{,*/}*.css', | ||
'styles/fonts/{,*/}*.*', | ||
'_locales/{,*/}*.json', | ||
'_locales/{,*/}*.json' | ||
] | ||
}] | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,37 @@ | ||
{ | ||
"name": "__MSG_appName__", | ||
"version": "0.10.0", | ||
"version": "1.0.2", | ||
"manifest_version": 2, | ||
"description": "__MSG_appDescription__", | ||
"icons": { | ||
"16": "images/icon-16.png", | ||
"128": "images/icon-128.png" | ||
}, | ||
"applications": { | ||
"gecko": { | ||
"id": "addon@fullyfeedly" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Out of curiosity, is it required to package the application for Firefox? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is more necessary to debug the application in Firefox since the local storage API requires the application ID to function. It's also required for publishing the extension to addons.firefox.com. |
||
} | ||
}, | ||
"default_locale": "en", | ||
"background": { | ||
"scripts": [ | ||
"scripts/chromereload.js", | ||
"scripts/background.js" | ||
], | ||
"persistent": false | ||
"scripts": ["scripts/chromereload.js", "scripts/browser-polyfill.js", "scripts/background.js"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is polyfill used to provide backward compatibility to certain browsers? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. The polyfill is used to provide compatibility for browsers that implement the chrome.* APIs but not the replacement browser.* APIs (i.e. Chromium-based browsers). Browser.* support is coming in Chromium, but it's not available yet, so this enables the same code to work across browsers. |
||
}, | ||
"page_action": { | ||
"browser_style": true, | ||
"default_icon": { | ||
"19": "images/icon-19.png", | ||
"38": "images/icon-38.png" | ||
}, | ||
"default_title": "fullyfeedly" | ||
"default_title": "Fully Feedly" | ||
}, | ||
"content_scripts": [ | ||
{ | ||
"matches": [ | ||
"*://*.feedly.com/*" | ||
], | ||
"matches": ["*://*.feedly.com/*"], | ||
"js": [ | ||
"bower_components/spin.js/spin.js", | ||
"bower_components/iosoverlay/js/iosOverlay.js", | ||
"bower_components/mousetrap/mousetrap.js", | ||
"scripts/browser-polyfill.js", | ||
"scripts/content.js" | ||
], | ||
"css": [ | ||
|
@@ -45,11 +46,13 @@ | |
"options.html" | ||
], | ||
"permissions": [ | ||
"declarativeContent", | ||
"activeTab", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not, however Chrome and Firefox implement the permission differently. ActiveTab in Firefox doesn't give you access to the URL while it does in Chrome. Tabs gives access to the URL in both. |
||
"tabs", | ||
"storage", | ||
"*://*.feedly.com/*", | ||
"https://boilerpipe-web.appspot.com/*", | ||
"https://mercury.postlight.com/*" | ||
], | ||
"options_page": "options.html" | ||
"options_ui": { | ||
"page": "options.html" | ||
} | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! I heard of this project but never had a chance to use it.
Does it actually re-format all the source files based on the style specified here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you run it at the command line on the project. There's also a great Visual Studio Code extension for it at https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode. It's great for making sure all of the files are formatted consistently.