Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create toolbar_icons_hover_zoom.css #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eMPee584
Copy link

/* This stylesheet makes main toolbar buttons nicely zoom on hover. */

@MrOtherGuy
Copy link
Owner

This is pretty neat effect, good job!

I can merge this, but I'm wondering why you are limiting the effect to only buttons in the nav-bar? I think it should apply to buttons regardless of which toolbar they are in.

Also, why the drop-shadows? I think if the user wants drop shadows for icons, they should use a style that does just that, and let this style be just what the name implies.

Which brings me to another issue, the name of the style. Or rather, there is already button_effect_scale_onhover.css, and that name is more fitting to this one I think. Unfortunately we can't merge these two sytles because they do different things. The old one scales just the icon, but this yours does scale the whole button.

Lastly, can I add the normal file header to this style? It would say:

/* Source file https://github.com/MrOtherGuy/firefox-csshacks/tree/master/chrome/toolbar_icons_hover_zoom.css made available under Mozilla Public License v. 2.0
See the above repository for updates as well as full license text. */

I want to include those mainly to inform whoever uses the style about where they can find the source but also to inform them about MPLv2 license.

So, if you don't have anything against it I would like to

  1. Make this apply to buttons in all toolbar, not just nav-bar.
  2. remove filter effects (drop-shadow)
  3. Change the file-name to something else.
  4. Add the normal header that is found in other styles.

I can do all of the above changes after merging if you prefer that. But do tell if you have strong opinions about why some of those should not be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants