Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacto(ocio): config overhaul #35

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

refacto(ocio): config overhaul #35

wants to merge 44 commits into from

Conversation

MrLixm
Copy link
Owner

@MrLixm MrLixm commented Apr 21, 2024 •
edited
Loading

Bif refactoring of the config

Changelog

Added

  • Introduce config variants and an OCIO v2 variant of the config: same config as v1 but taking benefit of specific OCIO v2 feature. Benefits are:
    • remove allocation vars (OCIO GPU engine)
    • use proper clamp in AgX Log
  • BT.2020 colorspace, with linear transfer-function

Changed

  • Simplified family for "view" colorspaces
  • ! new colorspace naming convention:
    • we try to follow the convention {gamut name}-{transfer function}(-{whitepoint}) so Linear sRGB become sRGB-linear
    • introduce the concept of "Image colorspace". An output-refered colorspace that include image and display rendering with an optional look.

Chore

  • split the build script into multiple modules to make code maintenance/browsing easier
  • introduce the variant concept in build script
  • automatise the generation of <View> and their colorspaces (Image Colorspaces)

MrLixm added 12 commits April 21, 2024 14:09
@MrLixm
refacto(ocio): pack config in variant subdir
599e7f8 
the plan is to have multiple config variants for users,
@MrLixm
refacto(ocio): add variants with OCIOv2 variant
d93d1d6
@MrLixm
refacto(.dev.ocio): define config path higher up
04c916f
@MrLixm
refacto(ocio): improve AgX Log clamp on OCIO v2
68d7917
@MrLixm
refacto(ocio): remove allocationVars on OCIOv2
6b3a431
@MrLixm
refacto(ocio): remove version from directory name
ab2a4a8
@MrLixm
fix(.dev.ocio): remove colorspace name set twice
43048f5
@MrLixm
feat(ocio): add "Linear BT.2020" colorspace
2b100b4
@MrLixm
feat(ocio): simplify the matrix transformations
cf48843
@MrLixm
refacto(ocio): improve Family for "view" colorspaces
0f18f46
@MrLixm
refacto(.dev.ocio): split code to own modules
1010832 
reduce the build script by splitting "utility" code to different modules
@MrLixm
refacto(ocio): reorganizing colorspaces; simplify EOTF
f6487ad
@MrLixm MrLixm added the enhancement New feature or request label Apr 21, 2024
@MrLixm MrLixm self-assigned this Apr 21, 2024
MrLixm added 16 commits April 21, 2024 19:30
@MrLixm
!refacto(ocio): new logic to build "image colorspaces"
89267f2 
- this reduce code duplication.
- the initial need is that we want each `view` to have its own colorspaces defined, for software that don't expose `views` in export options.
   - this mean we need to build a matrix of display colorspaces x image renderings x looks
   - we call those colorspaces "image colorspaces" as they produce a viewable image.
- we also renamed other colorspaces to have a more consistent and subjectively better naming convention
@MrLixm
refacto(.dev.ocio): improve variables name
663fe77
@MrLixm
!refacto(ocio): new AgXc rendering
fda39c3 
this is a breaking change fully changing the look over the previous version.
this is the result of multiple month of research based on other people work around AGX and image rendering.
the prototype of the rendering was achieved in nuke for fast iteration.

The new rendering:
- assume a BT.2020 working space
- use a double inset which wrap a new "luminance compensation" algorithm (whatever that means)
- use the outset concept
@MrLixm
refacto(ocio): rename AgX colorspace to AgXc
8279f83
@MrLixm
chore(ocio): upgrade config version to 1.0.0
90c0f30
@MrLixm
feat(ocio): expose AgXc-tonescale as colorspace
64905d8
@MrLixm
fix(ocio): Pre-Display display renamed to AgXc
35a00c7
@MrLixm
feat(python.grading): add tonemap_piecewise_power
4573cc7
@MrLixm
feat(python.tonescale): apply_AgX_tonescale: expose y pivot
f37f041
@MrLixm
feat(python.grading): add saturation_max
e651ac5
@MrLixm
refacto(ocio): new AgX look; softer IRT variant
f35d830 
renamed some colorspaces names for better readability
@MrLixm
chore(ocio): more details in README
5918056
@MrLixm
chore(ocio.CHANGELOG): add 1.0.0
2ea7a8b
@MrLixm
chore(pyproject): upgrade version to 1.0.0
9b1f5bb 
major change on ocio side
@MrLixm
refacto(ocio.build): rename sRGB-EOTF to sRGB-piecewise
2952bd4 
see https://community.acescentral.com/t/srgb-piece-wise-eotf-vs-pure-gamma/4024
@MrLixm
feat(ocio.build): add blender variant
efbb65e
MrLixm added 16 commits July 12, 2024 13:06
@MrLixm
refacto(ocio.build): improve variant object
e08b0a0 
create an instance for richer context attributes, instead of using enums
@MrLixm
feat(ocio.build): add "all-dcc" variant
86c9cd1
@MrLixm
chore(ocio.README): add details about variants
e9c5fbe
@MrLixm
chore(ocio.build): fix type hint for luts
e011a65
@MrLixm
feat(ocio.build): add commit hash in header
d25b9af 
the build being part of a commit we reference the previous commit, which is better than nothing even if not perfect.
@MrLixm
refacto(ocio.build): improve some colorspace description
e86c744
@MrLixm
fix(ocio.build): lut interpolation to tetrahedral
940aaad
@MrLixm
chore(ocio.README): document looks
ed1b50c
@MrLixm
refacto(ocio.build): renamed to AgXc_ocio_build
21ee710 
so it can be imported without name conflict
@MrLixm
chore(pyproject): add ocio dev modules to project install
d65829e
@MrLixm
chore(doc.images): update AgXc exposure-strip image
864f3e4 
use the v1.0.0 rendering
@MrLixm
chore(doc.images): update AgXc full image
5960778 
use the v1.0.0 rendering
@MrLixm
chore(doc.images): update AgXc combined image
a8ddbc4 
use the v1.0.0 rendering
@MrLixm
chore(ocio.build): set version to rc.1
2dacd5b 
planning to do a release-candidate before merging
@MrLixm
refacto(ocio.build): only enable sRGB,Pre-Display as active displays
64a6f20
@MrLixm
refacto(ocio.build): renamed sRGB-piecewise to sRGB-texture
7b8b31d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrLixm MrLixm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MrLixm