Redis counter does not increases with duplicate data from regulations #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to fix redis counter going up when duplicate data comes through from regulations. Made a callback function in Client which gets passed onto DiskSaver. when disksaver finds the path for the job doesn't exist, calls the callback, increasing the redis counter. Have to write code/test for the non-happy path
AlexF301
changed the title
|
Not sure if this was the best way to do this. feedback is appreciated |
|
@bjcoleman This seems relevant to the dashboard bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix redis counter going up when duplicate data comes through from regulations. Made a callback function in Client which gets passed onto DiskSaver. when disksaver finds the path for the job doesn't exist, calls the callback function from Client, increasing the redis counter.