Initial metadata extraction implementation #159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mment are found * This change uses the save_json method in the savers * Do note: The DiskSaver and S3 saver were using data with the full data dict before * I changed the Savers and the client to have the parameter for saving json be data["results"] instead of the full data dictionary * This is a better way of implementing the save_json methods since what is passed in is the json we want to save rather than needing to find the key we want in the savers themselves.
nikovacs
approved these changes
Apr 20, 2023
| meta["extraction_status"][file_name] = "Not Attempted" | ||
| meta_save_path = f"{meta_save_dir}/extraction-metadata.json" | ||
| self.saver.save_json(meta_save_path, meta) | ||
| return meta_save_path, meta |
There was a problem hiding this comment.
This method does not have to return anything. Otherwise good.
|
|
|
Not writing to S3 yet. |
|
After discussion with Dr. Coleman as well as understanding the time constraints at the end of the semester. We are putting the task of having extraction metadata off for now. At the moment, extraction metadata is a json of all the attachments in a docket and the statuses are initialized to "Not Attempted". We never got to having the extractor update this json due to the challenges with loading the file and the problems with this change in S3. |
|
The idea of having extraction metadata is still unclear about what exactly would be needed so this PR will need to be revisited at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.