Skip to content
This repository has been archived by the owner on Dec 21, 2024. It is now read-only.

feat: native Adventure support #3443

Open
wants to merge 7 commits into
base: 1.20.1
Choose a base branch
from

Conversation

SNWCreations
Copy link
Contributor

@SNWCreations SNWCreations commented Nov 27, 2024

Not fully implemented but should be enough for common purposes
Signed message features are not implemented because it will lead to so many changes on chat system and might break other chat-related mods
Really a huge change, pls review and test carefully!

Changes are ready to be reviewed but not ready to be merged as some cleanup on patches are needed, scheduled. Done.
Please remove commit messages while merging this as they are useless.

Not fully implemented but should be enough for common purposes
Signed message features are not implemented because it will lead to so many changes on chat system and might break other chat-related mods
@SNWCreations SNWCreations marked this pull request as draft November 27, 2024 22:33
Copy link
Contributor Author

@SNWCreations SNWCreations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some note for myself to cleanup patches

Not fully implemented but should be enough for common purposes
Signed message features are not implemented because it will lead to so many changes on chat system and might break other chat-related mods
@SNWCreations SNWCreations marked this pull request as ready for review November 28, 2024 05:11
@SNWCreations SNWCreations marked this pull request as draft November 28, 2024 11:49
@SNWCreations
Copy link
Contributor Author

Trying to implement more Adventure API for better compatibility with Paper plugins. maybe could solve issues like #3435

@SNWCreations SNWCreations marked this pull request as ready for review November 28, 2024 13:32
@SNWCreations SNWCreations marked this pull request as ready for review November 29, 2024 04:48
@XiaoJiang0208
Copy link

Is the TypeWriter plugin likely supported?

It's a good plugin, but only work on paper.

I'm trying to implement paper api,but I don't know where to start, can you give me some advice🥺

@SNWCreations
Copy link
Contributor Author

Is the TypeWriter plugin likely supported?

It's a good plugin, but only work on paper.

I'm trying to implement paper api,but I don't know where to start, can you give me some advice🥺

IDK will this PR content work well, you could check it out and compile it by yourself to do test.
If you know what part you're willing to implement, just setup a Paper userdev environment in a scratch plugin project, and copy-paste Paper implementation code behind API, solve compile failures, and test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants