Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding figure missing in vignette #158

Merged
merged 2 commits into from
Oct 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: shapviz
Title: SHAP Visualizations
Version: 0.9.5
Version: 0.9.6
Authors@R: c(
person("Michael", "Mayer", , "[email protected]", role = c("aut", "cre")),
person("Adrian", "Stando", , "[email protected]", role = "ctb")
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# shapviz 0.9.6

### Documentation

- Fixed wrong link vignette [#158](https://github.com/ModelOriented/shapviz/pull/158).

# shapviz 0.9.5

### User-visible changes
Expand Down
12 changes: 3 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
# shapviz 0.9.5 (RESUBMISSION)
# shapviz 0.9.6 (Fix CRAN errors)

Fixed duplicated vignette entry, as pointed out by the automatic checks by CRAN.

## Original message

Dear CRAN team

This update brings a new vignette, and improvements of the existing documentation.
One vignette points to a missing figure, leading errors or notes in different builds.

### Local checks

Expand All @@ -18,4 +12,4 @@ Status: OK

## Reverse dependencies (2)

2 OK
Not checked because the change affects only a vignette.
Binary file added man/figures/VIGNETTE-dep.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packaging.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ library(usethis)
use_description(
fields = list(
Title = "SHAP Visualizations",
Version = "0.9.5",
Version = "0.9.6",
Description = "Visualizations for SHAP (SHapley Additive exPlanations),
such as waterfall plots, force plots, various types of importance plots,
dependence plots, and interaction plots.
Expand Down Expand Up @@ -100,7 +100,7 @@ library(devtools)

document()
test()
check(manual = TRUE, cran = TRUE, vignettes = FALSE)
check(manual = TRUE, cran = TRUE, vignettes = TRUE)
build(vignettes = FALSE)
# build(binary = TRUE)
install(upgrade = FALSE)
Expand Down
Loading