Merge pull request #57 from mayer79/cran_060

Cran 060
ModelOriented · Mar 5, 2023 · c86edc9 · c86edc9
2 parents 961d9a5 + 37ec4c7
commit c86edc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 24 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
-Version: 0.5.0
-Date: 2023-02-03 11:14:39 UTC
-SHA: 097dce7331a12179ae5b45a869627f3d49efffc7
+Version: 0.6.0
+Date: 2023-03-05 16:47:24 UTC
+SHA: d9ee1aa8903020cb4ff34149f6e622a137be42d5
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,19 +1,6 @@
-# Re-Submission of shapviz 0.5.0
+# Submission of shapviz 0.6.0
 
-A pre-check failed:
-
-```
-Examples with CPU time > 2.5 times elapsed time
-               user system elapsed ratio
-sv_dependence 1.268  0.032   0.472 2.754
-```
-
-I have now set the parameter `nthread = 1` in fitting the XGBoost models in the
-examples, hoping to solve that issue.
-
-## Original message
-
-Dear CRAN team. "shapviz" now offers plots for SHAP interaction values - a feature that was on the wishlist for quite some time.
+Dear CRAN team. The dependence plot now uses better defaults. As they are user visible in some cases, the version jumps from 0.5.0 to 0.6.0. 
 
 ## Checks
 
@@ -24,16 +11,13 @@ Dear CRAN team. "shapviz" now offers plots for SHAP interaction values - a featu
 
 ### check_rhub()
 
-rhub notes
-
-NOTES:
 * checking package dependencies ... NOTE
-Packages which this enhances but not available for checking:
   'h2o', 'lightgbm'
+Packages which this enhances but not available for checking:
 * checking for detritus in the temp directory ... NOTE
 Found the following files/directories:
   'lastMiKTeXException'
-  
+
 ### check_win_devel()
 
-winbuilder: Status: OK
+Status: OK