Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midpoints and grid_only argument in univariate_grid() #98

Closed
wants to merge 1 commit into from

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Oct 29, 2023

This PR adds two new options to univariate_grid():

  1. midpoints = FALSE: Set to TRUE to get bin midpoints. This will be useful in plots that need to cut a numeric variable into histogram bins, while
  2. grid_only = TRUE: Should only the grid being returned, or also the approximation of the input?

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (98a3f15) 96.71% compared to head (0de35c4) 96.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   96.71%   96.54%   -0.17%     
==========================================
  Files          18       18              
  Lines         973      985      +12     
==========================================
+ Hits          941      951      +10     
- Misses         32       34       +2     
Files Coverage Δ
R/utils_grid.R 94.91% <92.00%> (-2.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 closed this Oct 29, 2023
@mayer79 mayer79 deleted the midpoints branch November 8, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants