Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swap_dim factor order #76

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix swap_dim factor order #76

merged 1 commit into from
Oct 13, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Oct 13, 2023

Using horizontal dodged barplots requires factor levels to be reverted for both y and fill aesthetic.

When swap_dim = TRUE, the fill aesthetic does not need to be reverted. This PR fixes this.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (366bd46) 96.39% compared to head (ea6205d) 96.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   96.39%   96.40%           
=======================================
  Files          18       18           
  Lines         916      917    +1     
=======================================
+ Hits          883      884    +1     
  Misses         33       33           
Files Coverage Δ
R/utils_plot.R 93.54% <100.00%> (+0.21%) ⬆️
R/utils_statistics.R 97.24% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit 79264d9 into main Oct 13, 2023
@mayer79 mayer79 deleted the wrong_facet_order branch October 13, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants