Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlr3 simplification #112

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Mlr3 simplification #112

merged 2 commits into from
Dec 26, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Dec 26, 2023

This PR replaces the overly complicated $predict() of mlr3 "Learners" by the usual predict(model, ...).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69e798b) 96.56% compared to head (a86cd74) 96.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          18       18           
  Lines        1049     1049           
=======================================
  Hits         1013     1013           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit fc764de into main Dec 26, 2023
7 checks passed
@mayer79 mayer79 deleted the mlr3-simplification branch December 26, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants