candidate fix for #48

ModelOriented · Aug 21, 2022 · 1e7d1b4 · 1e7d1b4
1 parent 6498abf
commit 1e7d1b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # fairmodels 1.2.1
 * changed CITATION file (added reference to the RJournal)
 * fix for https://github.com/ModelOriented/fairmodels/issues/49
+* fix for https://github.com/ModelOriented/fairmodels/issues/48
 
 # fairmodels 1.2.0
 * Added filtering metrics when plotting and printing of `fairness_object`. 

diff --git a/R/resample.R b/R/resample.R
@@ -127,6 +127,11 @@ resample <- function(protected, y, type = "uniform", probs = NULL, cutoff = 0.5)
       Xsc <- sum(protected == subgroup & y == actual_class)
       # formula for constructing the weights
       w_vec[actual_class + 1] <- (Xs * Xc) / (n * Xsc)
+      # fix for https://github.com/ModelOriented/fairmodels/issues/48
+      if (is.infinite(w_vec[actual_class + 1])) {
+        w_vec[actual_class + 1] = 0
+        warning("Infinite weights, set to 0. Probably sizes of some protected groups are too small")
+      }
     }
     num_sc <- append(num_sc, list(num_c))
     weight_list <- append(weight_list, list(w_vec))