-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metrics are added for imbalanced data #480
Conversation
Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcavs thank you,
for onboarding of new code please:
- add unit tests that will cover these additional functions to https://github.com/ModelOriented/DALEX/tree/master/tests
- add proper documentation (i.e. to https://modeloriented.github.io/DALEX/reference/model_performance.html)
- update https://github.com/ModelOriented/DALEX/blob/master/NEWS.md
@pbiecek 2 added and 3 updated, but I do not know how to add unit test :/ |
Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files). |
Hi @hbaniecki, I created a new pull request consists 2 and 3. You can see it on #505 |
Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.