Fix wrong row order in the plot.model_performance

ModelOriented · Jun 9, 2024 · d49cdc0 · d49cdc0
1 parent 28a936b
commit d49cdc0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: DALEX
 Title: moDel Agnostic Language for Exploration and eXplanation
-Version: 2.5.1
+Version: 2.5.2
 Authors@R: c(person("Przemyslaw", "Biecek", email = "[email protected]", role = c("aut", "cre"), 
              comment = c(ORCID = "0000-0001-8423-1823")),
     person("Szymon", "Maksymiuk", role = "aut",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+DALEX 2.5.2
+---------------------------------------------------------------
+* Fix wrong row order in the `plot.model_performance` ([#49](https://github.com/ModelOriented/DALEX/issues/49))
+
 DALEX 2.5.1
 ---------------------------------------------------------------
 * adding the support for calculating kernel SHAP values via `predict_parts()` function

diff --git a/R/plot_model_performance.R b/R/plot_model_performance.R
@@ -80,6 +80,9 @@ plot.model_performance <- function(x, ..., geom = "ecdf", show_outliers = 0, ptl
   }
 
   df$label <- reorder(df$label, df$diff, loss_function)
+  # Sort df based on the label's levels to make sure downstream functions relying
+  # on the rows order work appropriately
+  df <- df[order(df$label), ]
   if (ptlabel == "name") {
     df$name <- NULL
     df$name <- rownames(df)