Add setting to show notifications when downloads complete or fail#2338
Open
JonathanFeenstra wants to merge 2 commits intoModOrganizer2:masterfrom
Open
Add setting to show notifications when downloads complete or fail#2338JonathanFeenstra wants to merge 2 commits intoModOrganizer2:masterfrom
JonathanFeenstra wants to merge 2 commits intoModOrganizer2:masterfrom
Conversation
Contributor
Author
|
The lint check seems to fail because of this: jidicula/clang-format-action#267 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2045
Because showing notifications using
QSystemTrayIcon::showMessagerequires the tray icon to be visible, I changed the tray icon behavior to always show while Mod Organizer is running, instead of only while an executable with the "minimize to tray" option is running. I think it's okay to do it that way, since many other programs (especially game launchers like Steam, Epic, GOG, etc.) work like that as well.