Collect implicit dependencies added by swift_grpc_library for BwX
#2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thii
commented
Aug 27, 2023
thii
commented
thii
force-pushed
the
thi/bwx-collect-implicit-dependencies-added-by-swift_grpc_library
branch
from
72b7127 to
ba3119e
Compare
thii
changed the title
swift_grpc_libraryswift_grpc_library with BwX
thii
changed the title
swift_grpc_library with BwXswift_grpc_library for BwX
luispadron
approved these changes
Aug 28, 2023
brentleyjones
approved these changes
Aug 28, 2023
Signed-off-by: Thi Doãn <[email protected]>
Signed-off-by: Thi Doãn <[email protected]>
thii
force-pushed
the
thi/bwx-collect-implicit-dependencies-added-by-swift_grpc_library
branch
from
0e23b72 to
0b0a00e
Compare
brentleyjones
deleted the
thi/bwx-collect-implicit-dependencies-added-by-swift_grpc_library
branch
|
Looks like something in main broke this, I can't reproduce what's in the screenshot anymore. |
|
I think I know. I’ll look and put up a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.