Remove first paging iteration #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitalbuddha any concerns? |
digitalbuddha
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
+ Coverage 74.89% 75.32% +0.43%
==========================================
Files 38 38
Lines 920 920
Branches 168 168
==========================================
+ Hits 689 693 +4
+ Misses 144 142 -2
+ Partials 87 85 -2 |
Signed-off-by: Matt Ramotar <[email protected]>
matt-ramotar
force-pushed
the
matt-ramotar/rm-paging
branch
from
fc8689a to
deae226
Compare
itsandreramon
pushed a commit
to itsandreramon/Store
that referenced
this pull request
Feb 26, 2025
Signed-off-by: Matt Ramotar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is removing the first iteration of paging, which was introduced in 5.1.0-alpha01. I think paging should live under a
storexmodule inside the Store repo, but I think the paging artifacts should be versioned separately from Store. Will be able to focus on introducing the latest iteration of paging once Store 5.1.0 is stable. The latest iteration of paging is the one we shared at Droidcon NYC.