Include PrivacyInfo.xcprivacy manifest on Krono's target from Kronos.xcodeproj #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you had the chance to take a look at this PR, @keith @sberrevoets ? |
|
You'll need to fix the DCO check here. But lgtm |
keith
approved these changes
May 31, 2024
…xcodeproj - Add new script Copy Bundle Resource on Krono's Build Phase and include the PrivacyInfo.xcprivacy, otherwise when running xcodebuild create-xcframework command the manifest isn't included on Kronos.xcframework. Signed-off-by: Dídac Coll <[email protected]>
didix21
force-pushed
the
fix-privacy-manifest-kronos
branch
from
8df8a47
to
d48ac19
Compare
|
DCO fixed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new script Copy Bundle Resource on Krono's Build Phase and include the PrivacyInfo.xcprivacy, otherwise when running
xcodebuild -create-xcframeworkcommand the manifest isn't included on Kronos.xcframework.