Connects to #366. DEA search by protein names. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search by protein id Also: 1. Updated primary search instructions on the page 2. Updated function to convert manually input strings to arrays of search terms while keeping the auto-suggestion array as is 3. Updated placeholder text in search input field 4. Fixed bug in which selecting a different radio button didn't clear the manual input string in the search field 5. Removed commented JSX markup that is no longer needed
…_Search_Protein_Names
Also add reducers to support manual pagination controls.
Also add actions to support manual pagination controls.
…ta searches Also refactor code to support manual pagination controls.
…ntrols Also: * Add support for proteomics specific timewise DEA table display * Delete no longer needed global filter configs
…atted values are now in query response
…_Search_Protein_Names
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- src/Search/timewiseTable.jsx: Evaluated as low risk
Comments skipped due to low confidence (5)
src/Search/searchPage.jsx:508
- The clearInput function should be called within handleRadioChange to ensure the input field is cleared when the radio button changes.
clearInput();
src/Search/searchPage.jsx:134
- The example for metabolites should be enclosed in double quotes to match the new format.
return 'Example: "amino acids and peptides", "c10:2 carnitine"';
src/Search/searchPage.jsx:166
- The formatSearchInput function should handle cases where the input string is empty or contains only spaces.
return newArr;
src/Search/searchPage.jsx:254
- The toggleOmics function should be updated to use the correct parameter names.
onClick={toggleOmics.bind(this, 'omics', key)}
src/Search/searchReducer.js:17
- The variable 'keys' was changed from a string to an array. Ensure this change is consistently reflected throughout the codebase.
keys: [],
jyu-sm
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
is_metaflag in searching metabolite DEA results