Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connects to #291. Multi-omics working group data analysis resources. #292

Merged
merged 19 commits into from
Mar 14, 2024
Merged

Connects to #291. Multi-omics working group data analysis resources. #292

merged 19 commits into from
Mar 14, 2024

Conversation

jimmyzhen
Copy link
Contributor

@jimmyzhen jimmyzhen commented Mar 13, 2024 •
edited
Loading

Key Changes:

  • Added a link panel on Search page that directs users to the new multi-omics working group data analysis resources page when clicked on. This link panel is only available to consortium members after they successfully sign into the Data Hub portal.
  • Added a new page to list the multi-omics working group data analysis resources, with links to Google Drive folders and documents. Links under the Analysis Reports will invoke a modal containing an iframe to display the external HTML analysis reports.
  • Fixed link to CFDE portal from our linkout page.
  • Deleted the no longer used mocked graphical result report files.
  • Upgraded app module dependencies.

@jimmyzhen
Upgrade dependencies
4beefd2
@jimmyzhen
Bumped version of Victory npm module to resolve compilation error
f299804
@jimmyzhen
Add feature link to multi-omics wg resources
554253a
@jimmyzhen
Add private route to multi-omics wg component
0686da2
@jimmyzhen
Initial commit of multi-omics wg resources component
98ec196
@jimmyzhen
Add styling to multi-omics wg resources feature link
25d976a
@jimmyzhen
Initial commit of mocked markup of notebook
7a39e61
@jimmyzhen
Remove no longer needed html graphical cluster reports
0a3c9f5
@jimmyzhen
Fix URL to CFDE portal
f631f20
@jimmyzhen
Renamed file
14185cc
@jimmyzhen
Initial commit for dawg-pac analysis html report modal
8941b93
@jimmyzhen
Add proteomics html reports and refactor code
3fc231c
@jimmyzhen
Move file to new folder
05966a4
@jimmyzhen
Set default height for modal and iframe (for now)
83fd907
@jimmyzhen
Update report paths
ae8b7a2
@jimmyzhen
Set modal header title to report file name
3d7a54f
@jimmyzhen
Add new proteomics reports and re-order omics report list
3e18ec5
@jimmyzhen
Move file out of 'qc' subfolder
8682f23
@jimmyzhen
Initial commit of 5 mocked html reports
ee29100
@jimmyzhen jimmyzhen linked an issue Mar 13, 2024 that may be closed by this pull request
Multi-omics Working Groups Resources #291
Closed
@jyu-sm
Copy link
Collaborator

jyu-sm commented Mar 13, 2024

lgtm

cteng585
cteng585 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@cteng585 cteng585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me.

My one piece of feedback is with respect to the MAWG links. If one of the uses of this page is for onboarding new MoTrPAC members, it may be useful to spell out the abbreviations with acronyms included (e.g. Data Analysis - DA) instead of just the acronyms.

@jimmyzhen jimmyzhen merged commit 76cbde3 into dev Mar 14, 2024
3 checks passed
@jimmyzhen jimmyzhen deleted the 291_JZ_Multiomics_WG_Resources branch May 30, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cteng585 cteng585 cteng585 approved these changes

@jyu-sm jyu-sm Awaiting requested review from jyu-sm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-omics Working Groups Resources
3 participants
@jimmyzhen @jyu-sm @cteng585