Load dogwood theme as submodule #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these will be loaded using a submodule in future commits
- to be honest, I copied this verbatim from my MapRVA/maprva.github.io repo (of the same license), perhaps it could be streamlined
- I didn't see a mono logo available in this repo for Missing Maps, so I set the regular one to be the mono one too in _config.yml so that the default dogwood one wouldn't display.
- this prevents the dogwood theme from displaying the icon in the first place
- also, bump version of configure-pages Action
|
Also, nota bene that local development will require explicitly cloning the submodule. This can be done with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all (most?) dogwood theme code into a submodule of the dogwood repository itself, in the
/dogwooddirectory. This allows for newer versions of the theme to be applied to this site by updating the submodule. I made a couple of further changes to restore this site to what it looked like before this PR, for example I changed color defaults to their original values using the_sass/dogwood/custom-variables.scssfile. See my commit notes below for more information.My branch successfully builds this PR, hopefully it will continue to work once merged.
@nicolelaine, it was nice to meet you at SOTMUS!