fix: fixing NRE when DestroyObject is called on unspawned object

SendToRemoteObservers throws because server reference is not set
MirageNet · Sep 4, 2024 · ce00f0d · ce00f0d
1 parent 32a061c
commit ce00f0d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Assets/Mirage/Runtime/ServerObjectManager.cs b/Assets/Mirage/Runtime/ServerObjectManager.cs
@@ -597,7 +597,13 @@ public void Destroy(NetworkIdentity identity, bool destroyServerObject = true)
 
         private void DestroyObject(NetworkIdentity identity, bool destroyServerObject)
         {
-            if (logger.LogEnabled()) logger.Log("DestroyObject instance:" + identity.NetId);
+            if (identity.NetId == 0)
+            {
+                if (logger.WarnEnabled()) logger.LogWarning("DestroyObject instance:" + identity.NetId);
+                return;
+            }
+
+            if (logger.LogEnabled()) logger.Log($"DestroyObject NetId={identity.NetId}");
 
             _server.World.RemoveIdentity(identity);
             identity.Owner?.RemoveOwnedObject(identity);