-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folia Support #915
base: master
Are you sure you want to change the base?
Folia Support #915
Conversation
Seems to be working with Essentials' folia branch |
Can confirm this iteration of Vault works perfectly. An indirect issue that is not expected to work accordingly is the update checker. Other than that, placeholders with the experimental PlaceholderAPI branch also work in plugins like TAB, in which already works pretty well at its current state. |
The update check should be working with this PR. Is it not working for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this build LOOHP has made. It works perfectly fine, and I have not received any errors while using it. I tested this plugin with a plugin called BetterEconomy which also updated with Folia support. Here is the spigot link to BetterEconomy - https://www.spigotmc.org/resources/bettereconomy.96690/history
I removed the Bukkit Scheduler implementation to use the Concurrent Executors implementation which is much more maintainable than using an implementation that requires to use another package for Folia like here MilkBowl#915
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any plan to merge this?
https://github.com/PaperMC/Folia
Marked as Draft as it is to be tested with Essentials Economy once that comes out (Done)