Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folia Support #915

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Folia Support #915

wants to merge 3 commits into from

Conversation

LOOHP
Copy link

@LOOHP LOOHP commented Mar 30, 2023

https://github.com/PaperMC/Folia

Marked as Draft as it is to be tested with Essentials Economy once that comes out (Done)

@LOOHP LOOHP marked this pull request as ready for review March 31, 2023 14:15
@LOOHP
Copy link
Author

LOOHP commented Mar 31, 2023

Seems to be working with Essentials' folia branch

@R00tB33rMan
Copy link

Can confirm this iteration of Vault works perfectly. An indirect issue that is not expected to work accordingly is the update checker. Other than that, placeholders with the experimental PlaceholderAPI branch also work in plugins like TAB, in which already works pretty well at its current state.

@LOOHP
Copy link
Author

LOOHP commented Apr 5, 2023

The update check should be working with this PR. Is it not working for you?

Copy link

@Yomamaeatstoes Yomamaeatstoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this build LOOHP has made. It works perfectly fine, and I have not received any errors while using it. I tested this plugin with a plugin called BetterEconomy which also updated with Folia support. Here is the spigot link to BetterEconomy - https://www.spigotmc.org/resources/bettereconomy.96690/history

Euphillya added a commit to Euphillya/Vault that referenced this pull request Apr 15, 2023
I removed the Bukkit Scheduler implementation to use the Concurrent Executors implementation which is much more maintainable than using an implementation that requires to use another package for Folia like here MilkBowl#915
Copy link

@vLuckyyy vLuckyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plan to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants