Transformation NPE crash #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… null, and causing a NPE later on Whenever two (or more) transformers would fulfil their conditions at once, the first one would correctly pass the tank's fluid over to inputStack and remove the fluid, but the second transformer would retrieve the null fluid and assign it to inputStack. This would set the NBT data to null, causing a NPE both in the barrel's render method due to a null stack, and in the update method due to passing null to the transformer.
This previously caused a crash when stack itself was null, and now defaults to a missing sprite
This previously caused a crash when inputStack was null. The method now checks for both, but remains lenient if transformer is already set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
The crash is caused by multiple transformers fighting over
inputStack. The first one sets the tank contents to null, and every subsequent container takes that null value and assigns it toinputStack. This writes it to NBT and causes NPEs later on during render and update.(Note: compilation was not tested as I couldn't set up the toolchain properly, but it is verified by editing and patching the bytecode of the compiled mod.)