Added ability to pass options to SqlBulkCopy for bulk insert #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al parameters - transaction and copy options.
RedDeathGitHub
commented
Aug 10, 2017
| @@ -56,7 +56,9 @@ public void InsertItems<T>(IEnumerable<T> items, string schema, string tableName | |||
| { | |||
| con.Open(); | |||
| } | |||
| using (SqlBulkCopy copy = new SqlBulkCopy(con)) | |||
| using (var copy = transaction == null | |||
| ? new SqlBulkCopy(con.ConnectionString, copyOptions) | |||
There was a problem hiding this comment.
Overloads for SqlBulkCopy are a bit weird, I have to use a string connection here.
This was referenced Feb 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is my first contribution, so apologies if this is not done right.
I find the library very useful, but I need to pass specific options to SqlBulkCopy when doing bulk insert.
So I created this fork to showcase my changes and ask if you find them useful to merge into the main library.
I tried to do this as a non-breaking change, so my additional parameters are all optional - this should not break existing code.
All tests seem to pass on my local machine.
Please let me know if you find this a worth-while addition, and please update the nuget version so I would be able to use these changes.
Alternatively I'll just use this as a local file library.
Cheers!