-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tank indexing in the Transposer's transferFluid method #3659
base: master-MC1.12
Are you sure you want to change the base?
Conversation
@@ -48,7 +48,7 @@ trait InventoryTransfer extends traits.WorldAware with traits.SideRestricted { | |||
val sinkSide = checkSideForAction(args, 1) | |||
val sinkPos = position.offset(sinkSide) | |||
val count = args.optFluidCount(2) | |||
val sourceTank = args.optInteger(3, -1) | |||
val sourceTank = args.optInteger(3, -1) - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@repo-alt What do you think? This is a change we pulled from GT:NH in 2022, and using 1-based indexes does make sense, but how much production code would breaking this break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will break some code of course, and there is no easy way to notify the user about that change, but the change makes sense indeed, so I don't think you should look back at us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. In this case I'll probably keep it for a larger release, like 1.9.0 (if it ever happens - at this rate, I doubt it!).
I'm fine with removing the indexing change for now, but the transfer limit fix is pretty important for precise fluid movement (I originally found it when trying to automate a Tinker's smeltery). |
Understood. I'll try to ship a patch release soon. I apologize for taking so long; the mod no longer has active maintainers, and I don't have much of an interest in Minecraft mod development anymore. |
This updates the `sourceTank` parameter to be 1-based when called from Lua.
d1ffc5d
to
2fea540
Compare
I just rebased and updated the PR description to reflect just the indexing change. Thanks for the maintenance you are doing, however minimal it may be 😃 |
This updates the
sourceTank
parameter to be 1-based when called from Lua.